Pull Requests - Besu - LF Decentralized Trust


    
        
            
                
                                

        


        
            

            






Atlassian uses cookies to improve your browsing experience, perform analytics and research, and conduct advertising. Accept all cookies to indicate that you agree to our use of cookies on your device. Atlassian cookies and tracking notice, (opens new window)
PreferencesOnly necessaryAccept all









LF Decentralized Trust

LF Decentralized Trust

Spaces

Apps
Templates

Create
























Besu




	All content



Shortcuts



	Meetings

Meetings


 This trigger is hidden

	How-to articles

How-to articles


 This trigger is hidden






Content







Results will update as you type.

	Code of Conduct





	Contributing




	I just have a quick question





	First contribution





	Issues





	DCO





	Suggesting Enhancements





	Pull Requests





	Code Reviews





	Reporting Bugs





	Copyright and License





	Discord





	Curators







	Developing and Conventions





	Documentation





	Community





	Governance





	Programs & Grants





	Meetings





	Design Documents





	Security





	Audits





	Start Here





	Performance & Stability





	How-to articles





	Incident Reports





	Besu Roadmap & Planning





	How to Contribute



















You‘re viewing this with anonymous access, so some content might be blocked.
Close













Besu

/
Pull Requests












More actions







Pull Requests

	Felipe Faraggi



	Sally MacFarlane



	Nicolas Massart





Owned by Felipe Faraggi


Last updated: Sept 15, 2024 by Sally MacFarlane










Pull Requests
The process described here has several goals:
	Maintain Product quality
	Fix problems that are important to users
	Engage the community in working toward the best possible product
	Enable a sustainable system for maintainers to review contributions
	Further explanation on PR & commit messages can be found in the How to Write a Git Commit Message article by Chris Beams.

Please follow these steps to have your contribution considered by the approvers:
	Ensure all commits have a Sign-off for DCO, as described in [DCO.md].
	Follow all instructions in PULL-REQUEST-TEMPLATE.md.
	Include appropriate test coverage. Testing is 100% automated. All submissions must be testable in an automated fashion.
	Follow the Style Guides.
	After you submit your pull request, verify that all status checks are passing.

What Makes A Good Pull Request?
The following guidelines, based on Fabric's contribution guidelines will help ensure that your pull request gets promptly reviewed.
One Pull Request, One Change
	This limits the surface area of the change, and makes it easier to identify root causes when issues arise.
	Make sure your PR doesn't display commits that are not part of it. This may happen if your fork is not up to date.

Link to Issue
	When submitting your PR, include the issue's link in the description and number in the title (i.e. [BESU-99] My Awesome PR), this helps provide more context on your work and auto-update the issue ticket to include a link to your PR.

Minimize lines of code (LOC) per PR
	PRs get near exponentially longer to review as the number of lines of code increase. Ideally, try and keep your changes to under 300 LOC. If that is not possible, try and break up your PR into smaller ones for reviewers to review sequentially.
	One way to do this if, for some reason, the change has to all go in the codebase at once, is to have a PR open on the Besu repository linking to smaller PRs on your Besu fork.

Write Meaningful Commit Messages
	As mentioned above, your commit title should include the issue number (i.e. [BESU-99]) while the description should link to the issue. Please include a comprehensive description of the changes in your commit description.

Be Responsive
	Don't let a PR sit idle with unaddressed comments until it gets to a point where you need to rebase the whole thing. If you are pausing your work on an issue, please indicate it in the PR comments. You can also change your PR to draft status.

What if the status checks are failing?
	If a status check is failing, and you believe that the failure is unrelated to your change, please leave a comment on the pull request explaining why you believe the failure is unrelated. A maintainer will re-run the status check for you.
	If we conclude that the failure was a false positive, then we will open an issue to track that problem with our status check suite.

Code Review
While the prerequisites above must be satisfied prior to having your pull request reviewed, the reviewer(s) may ask you to complete additional design work, tests, or other changes before your pull request can be ultimately accepted. Please refer to Code Review.







, multiple selections available,





Related content
More info

Collapse
Release Process
Release Process

Besu



More like this






DRAFT DOCUMENT - Best Practices for Automated Pipelines
DRAFT DOCUMENT - Best Practices for Automated Pipelines

Task Forces



More like this






Evernym Team Process
Evernym Team Process

Hyperledger Indy



More like this






Documentation contribution workflow
Documentation contribution workflow

Besu



More like this






Developer Guide Outline/Draft
Developer Guide Outline/Draft

Diversity, Civility, and Inclusion WG (archived)



More like this






Link GitHub to Discord
Link GitHub to Discord

Community Architects



More like this

































































        

    


    {"serverDuration": 11, "requestCorrelationId": "03f5b63533cd485592350e186d9cc1b0"}